Skip to content

removes smart quotes for favicon in inst/BS5/templates/head.html #3006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
njtierney wants to merge 4 commits into
base: main
Choose a base branch
from
Open

removes smart quotes for favicon in inst/BS5/templates/head.html #3006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f74cd18
removes smart quotes for favicon in inst/BS5/templates/head.html
njtierney Jul 6, 2026
8015a41
Also fix smart quote in bs3 template
njtierney Jul 8, 2026
076cfb1
NEWS bump
njtierney Jul 8, 2026
87f7d53
add user and issue number for news bump
njtierney Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
* Test fix for `R CMD check`.
* When previewing a site, it is now served via a local http server. This enables dynamic features such as search to work correctly (@shikokuchuo, #2975).
* Code in a link (href) is no longer autolinked (#2972)
* Ensure SVG favicons are parsed properly by fixing a bug in BS5 and BS3 favicon icon templates where curly/smart quotes (”…”, U+201D) were used instead of straight quotes, which caused the SVG favicon to not be used and a fallback raster favicon to be used. If your fallback was low resolution, your favicon looked poor (@njtierney, #3005).

@maelle maelle Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please move this item to the dev version section above? Thank you!


# pkgdown 2.2.0

Expand Down
2 changes: 1 addition & 1 deletion inst/BS3/templates/head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
{{#has_favicons}}
<!-- favicons -->
<link rel="icon" type="image/png" sizes="48x48" href="{{#site}}{{root}}{{/site}}favicon-48x48.png">
<link rel="icon" type=”image/svg+xml” href="{{#site}}{{root}}{{/site}}favicon.svg">
<link rel="icon" type="image/svg+xml" href="{{#site}}{{root}}{{/site}}favicon.svg">
<link rel="apple-touch-icon" sizes="180x180" href="{{#site}}{{root}}{{/site}}apple-touch-icon.png">
<link rel="icon" sizes="any" href="{{#site}}{{root}}{{/site}}favicon.ico" >
<link rel="manifest" href="{{#site}}{{root}}{{/site}}site.webmanifest">
Expand Down
2 changes: 1 addition & 1 deletion inst/BS5/templates/head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{{#has_favicons}}
<!-- favicons -->
<link rel="icon" type="image/png" sizes="96x96" href="{{#site}}{{root}}{{/site}}favicon-96x96.png">
<link rel="icon" type=”image/svg+xml” href="{{#site}}{{root}}{{/site}}favicon.svg">
<link rel="icon" type="image/svg+xml" href="{{#site}}{{root}}{{/site}}favicon.svg">
<link rel="apple-touch-icon" sizes="180x180" href="{{#site}}{{root}}{{/site}}apple-touch-icon.png">
<link rel="icon" sizes="any" href="{{#site}}{{root}}{{/site}}favicon.ico" >
<link rel="manifest" href="{{#site}}{{root}}{{/site}}site.webmanifest">
Expand Down
Loading