Skip to content

Fixed hardcoded executable location#7

Open
Mailaender wants to merge 1 commit into
quozl:masterfrom
Mailaender:patch-1
Open

Fixed hardcoded executable location#7
Mailaender wants to merge 1 commit into
quozl:masterfrom
Mailaender:patch-1

Conversation

@Mailaender

Copy link
Copy Markdown

options like `--bindir=PATH' to specify different values for particular
is configurable so it shouldn't be hardcoded here.

@solbu

solbu commented Oct 31, 2021

Copy link
Copy Markdown

Except in this case it is the default location.

In your suse package you override the bindir variable.
Games are supposed to install their binaries in /usr/games/,
which in rpm is accomplished by the «BINDIR=${prefix}/games» variable in the system.mk(.in) file.

A proper fix would be to put the desktop file in a desktop.in, with the variable used by «configure» to determine it.
Your proposed change will break most distros packages, resulting in them having to patch the desktop file by themselves.

I vote NO on this merge.

(EDIT: Corrected games binary path)

@solbu

solbu commented Oct 31, 2021

Copy link
Copy Markdown

And the reason for the hardcoding is that on many distros the folder «/usr/games» is Not part of the PATH variable.

@quozl

quozl commented Oct 31, 2021

Copy link
Copy Markdown
Owner

I've no time right at the moment ... except to say that I expect BINDIR configuration to be cascaded from Autoconf to the desktop file, so that means renaming it to an .in file and referencing in configure.ac AC_OUTPUT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants