Skip to content

Fix memory leak from retained exception tracebacks #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woolimcho merged 1 commit into from
Apr 8, 2026
Merged

Fix memory leak from retained exception tracebacks #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions asynq/async_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ def _computed(self):
# super() doesn't work in Cython-ed version here
self._dependencies = []
self._last_value = None
self._frame = None # Release frame reference to prevent retention
futures.FutureBase._computed(self)
error = self.error()

Expand Down Expand Up @@ -218,9 +219,15 @@ def _continue_on_generator(self, value, error):
else:
self._frame = debug.get_frame(self._generator)
if hasattr(error, "_task"):
return self._generator.throw(error._type_, error, error._traceback)
try:
error.__traceback__ = error._traceback
return self._generator.throw(error)
finally:
# Traceback has been propagated into the generator;
# clear the stored copy to prevent frame retention
error._traceback = None
else:
return self._generator.throw(type(error), error)
return self._generator.throw(error)
except (StopIteration, GeneratorExit):
# Returning leads to a StopIteration exception, which is
# handled here. In this case we shouldn't need to extract frame
Expand Down
Loading