Skip to content

Fix .asyncio() on async_proxy returning ConstFuture #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilevkivskyi-quora merged 2 commits into from
Jun 6, 2025
Merged

Fix .asyncio() on async_proxy returning ConstFuture #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23dbd19
Fix .asyncio() on async_proxy returning ConstFuture
ilevkivskyi-quora Jun 6, 2025
e481057
black
ilevkivskyi-quora Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion asynq/decorators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,10 @@ def asyncio(self, *args, **kwargs) -> Coroutine[Any, Any, Any]:
asyncio_fn = convert_asynq_to_async(self.fn)

async def unwrap_coroutine(*args, **kwargs):
return await (await asyncio_fn(*args, **kwargs))
fut = await asyncio_fn(*args, **kwargs)
if isinstance(fut, futures.ConstFuture):
return fut.value()
return await fut

self.asyncio_fn = unwrap_coroutine

Expand Down
8 changes: 8 additions & 0 deletions asynq/tests/test_asynq_to_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,14 @@ def f1():
assert asyncio.run(f1.asyncio()) == 100


def test_proxy_const():
@asynq.async_proxy()
def f1():
return asynq.ConstFuture(42)

assert asyncio.run(f1.asyncio()) == 42


def test_proxy_and_bind():
async def async_g(self, x):
return x + 20 + B.SELF
Expand Down