Make end armor trimmable / add end trim materials#440
Open
OpenBagTwo wants to merge 7 commits into
Open
Conversation
Author
cfe5c44 to
3557606
Compare
TODO: vanilla armors
while I'm in here
Author
|
With 433b82b, this PR now additionally updates the language file entries for the music discs. Alternatively, @frankbauer, you could update the datagen to simply specify the old locations for the jukebox song names. That is, there's nothing to say that in the couldn't still point to: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Coulda sworn there was an issue asking for this, but anyway, my 9yo has been begging for it 😆
A few notes:
{material}_{piece}_{trim}_trim.jsonfiles