Fix armored elytra rendering and armor stats#437
Conversation
|
After 7c82ecc, I confirmed that the following armor stats matched what they were on 1.20.4: Crystalite
Aeternium
*These were 1.0 previously, and are zero now. I took this as an intentional nerf. If that was not the case, I'm happy to change them back to 1. |
|
@frankbauer this PR should now resolve #442 / #419 |
960b53a to
d5a2060
Compare
|
Now corrects an oversight in #438 where I hadn't realized I needed to explicitly register End Veil as a tradeable enchant |
|
Now resolves #449, though @frankbauer, if you'd prefer to implement this in the datagen, I can remove that commit from this PR. |
|
How do i get these fixes? |
|
I don't know a lot about how this works but this doesn't seem to allow the crystalite elytra to be enchanted with unbreaking and mending. I could enchant with prot 4 and thorns 3 though |
BCElytraItem / FabricElytraItem does not actually inherit from Items.ELYTRA
This will almost certainly be something that should be done automatically via datagen
|
Just pushed three more fixes around Crystalite armor. @tonitch Just using an enchanting table, right? I've been able to add enchantments with an anvil, but I can't figure out what tag I'm missing to allow them to get Unbreaking. |
BCLElytraItem/FabricElytraItemdoes not actually inherit fromItems.ELYTRAwhich is why this was failing.I was worried about not having the
== nullcheck that's in the current 1.20.3 branch code, but not only does the IDE complain about it if I include it (says thatitemStackis nevernull), but the rendering behavior works fine without it—third-person renders as expected when I un-equip my armored elytra or when I use a regular elytra or chestplate.