Fix return portal position calculation for dragon respawn#346
Open
OpenBagTwo wants to merge 2 commits into
Open
Fix return portal position calculation for dragon respawn#346OpenBagTwo wants to merge 2 commits into
OpenBagTwo wants to merge 2 commits into
Conversation
...for dragon fight respawn
Author
|
Looks like this is fixed on 1.21, but I would still highly recommend you merge this into the 1.20.3 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #327 by
explicitly flooringremoving the (now)-unnecessary translations applied to the X and Z coordinates ofthis.portalLocationValidation Performed
In both cases, the log message read:
though, so if there are scenarios where the portal could be elsewhere, I haven't confirmed that to be working.
Also note that I'm only checking from y=0 to y=255 (rather than -255 to 255) because I don't think there's any scenario in which the portal will generate at a negative y level (if I'm wrong, feel free to change back!)
Stepping back, I realize that this actually could have been a two-line change to just remove the +/- 1 from
BetterEnd/src/main/java/org/betterx/betterend/mixin/common/EndDragonFightMixin.java
Lines 77 to 78 in 35c56c5
so feel free to just do that instead and close this PR.