fix: get setting values from oneclirc#4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the configuration handling for commands and adds a development mode to the CLI script. The most significant changes are the introduction of a function to retrieve command-specific settings, updating the
hellocommand to use this function, and adding a "dev" mode to the CLI entrypoint for easier local development.Configuration handling improvements:
settings_for_commandincommon/config.pyto retrieve command-specific settings, allowing command-level overrides of global configuration.hellocommand (commands/hello/__init__.py) to usesettings_for_command("hello")instead of the previous globalsettings, enabling it to respect command-specific configuration.CLI usability enhancement:
onecliscript to add a "dev" mode: runningonecli dev ...now mounts the current directory into the container, making local development and testing easier.