refactor: change filter engine#11
Merged
Merged
Conversation
…senior stock command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and extends the filtering logic for the
senior-stockcommand, introducing a new, more flexible filtering engine and updating the CLI interface and documentation to support a broader set of filter operations. The change also updates the tests to match the new syntax and behavior.Filtering system overhaul:
FilterEngineclass incommon/filter.pythat supports multiple filter types (e.g.,[eq],[re],[ne],[lt],[gt],[contains], etc.), allowing for much more expressive and powerful filtering on stock data. The filter logic is now centralized and easier to extend.commands/senior-stock/__init__.pywith the newFilterEngine, removing theparse_filtersfunction and updating the command to use the new engine for all filtering. [1] [2] [3]CLI and documentation updates:
--filter,--columns, and--all-columnsoptions to document the new filter syntax and available filter types, improving usability and discoverability.ean[eq]12345instead ofean:12345). [1] [2]Testing updates:
tests/commands/senior-stock/test_command.pyto cover the new filter syntax and additional filter types, ensuring correctness and backwards compatibility. [1] [2] [3] [4]