expose GenerateConfig via JSON C API#394
Merged
Merged
Conversation
752303c to
dd0d6f2
Compare
quietvoid
reviewed
Apr 11, 2026
quietvoid
reviewed
Apr 11, 2026
dd0d6f2 to
5852a8d
Compare
quietvoid
reviewed
Apr 11, 2026
Takes a JSON-serialized GenerateConfig, deserializes it, generates RPUs via generate_rpu_list, and returns an RpuOpaqueList. Gated on capi + serde features. Follows the same pattern as dovi_parse_rpu_bin_file for the return type.
5852a8d to
21b8b63
Compare
Owner
|
Looks good to me, might do some refactor after.
FYI there will most likely be a C API function for creating a single RPU from a HDR10+ SEI payload. This new generate function isn't ideal for a single RPU. |
Owner
|
I think I'll have to force all the features for C API building by default so that packaging is easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion: single function that takes a JSON string, deserializes to GenerateConfig, generates RPUs, returns RpuOpaqueList. Same return type as dovi_parse_rpu_bin_file.
Gated on
capi+serdefeatures. serde_json dependency was already there.Our use case (HDR10+ to P8.1, RPU writer code from cpm/avdvplus): build the JSON config per frame with L1 values from HDR10+ conversion, generate one RPU, write it. Replaces ~280 lines of hand-written RPU bitstream in C++.