Add PMD to Ensure Code Quality and Best Practices#45595
Closed
Pankraz76 wants to merge 2 commits into
Closed
Conversation
Pankraz76
commented
Jan 14, 2025
Author
|
is this any good ? |
Pankraz76
marked this pull request as ready for review
January 14, 2025 22:30
Contributor
|
As mentioned in the discussion in #45417, we are not going to add this tool the repo |
Pankraz76
commented
May 20, 2025
| <excludeFromFailureFile>${project.basedir}/.pmd/exclude.properties</excludeFromFailureFile> | ||
| <printFailingErrors>true</printFailingErrors> | ||
| </configuration> | ||
| <executions> |
Author
There was a problem hiding this comment.
rule set here is missing. This is just subset of whats really going on.
Pankraz76
commented
May 20, 2025
| io.quarkus.logging.Log=UnnecessaryFullyQualifiedName | ||
| io.quarkus.runtime.BlockingOperationControl=UnnecessaryFullyQualifiedName | ||
| io.quarkus.runtime.LaunchMode=UnnecessaryFullyQualifiedName | ||
| io.quarkus.runtime.configuration.NameIterator=EmptyControlStatement |
Author
There was a problem hiding this comment.
if maven has 500, might be here 2k due to the huge code base.
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates the Maven PMD Plugin to enforce code quality standards and best practices. Key updates include:
pom.xmlwith caching and exclusions..pmd/exclude.propertiesfor managing ignored violations..gitignoreto exclude.pmd/.cache.Common rules like
TooManyStaticImportsare acceptable to remain, but other exclusions should be reconsidered and removed step by step.