issue-804: ADR for devui editor roundtrip test - #805
Conversation
fantonangeli
left a comment
There was a problem hiding this comment.
LGTM, for the parts which I can understand.
Thanks @domhanak
|
@domhanak Thanks for the ADR, my knowledge of quarkus flow internals is limited but looks like a great start. Just one small comment:
So can we run the same check across the other types: |
|
@lornakelly yea, so I initially did not include this when prompting, so it is not there. Wanted to keep the focus narrow to limit hallucinations and inaccuracies. So this ADR covers the MVP, the expansion to broader coverage can be done in multiple ways, but we need one where we reuse existing example workflows so it is a bit tricky. I have since theorized a way to reuse what we have in Ultimately we could do one big workflow that has everything here, but that is something I did not think through yet. |
Sounds good, thanks |
Wire docs/modules/ROOT/examples as an extra test source in core/deployment/pom.xml via build-helper-maven-plugin + compiler excludes
dd a lightweight JSON-RPC companion test (no browser) that validates JsonRPC roundtrip idempotency, semantic equivalency and registry mutation
Verify the round-trip for a workflow loaded from a YAML resource file using the same idempotency and semantic-equivalence assertions as in Java fixture
Create the new Playwright-based round-trip IT that validates the full rendering pipeline for **Java DSL workflows** from `docs/modules/ROOT/examples/org/acme/`
| <!-- Requires LangChain4j dependencies --> | ||
| <exclude>org/acme/langchain4j/**</exclude> | ||
| <!-- Doc test classes — use their own QuarkusTest setup, not applicable here --> | ||
| <exclude>test/**</exclude> |
There was a problem hiding this comment.
Are these exclusions because of the inclusion of docs sources in builder-helper-maven-plugin? If so, can you please add a comment here explaining this?
There was a problem hiding this comment.
Sure, I ll add comment explaining
Description
This is an ADR for a test to validate Dev UI Workflow Editor Rendering Round-Trip
ADR for #804
Updated with:
Added PoC test suite with cases
Update the ADR based on PoC
Changes
Adds ADR for #804
Checklist
Before submitting this PR, please ensure:
./mvnw clean install -DskipITs=falseAdditional Notes