Aling and Update workflow and task routing configuration to use namespace:name version format

[matheusandre1]

Closes: #677

[github-actions]

🙈 The PR is closed and the preview is expired.

[mcruzdev]

Hey @matheusandre1, currently the HTTP routes workflows and tasks to HTTP client (see here).

Currently the gRPC implementation allows us to route based in more options (see my PR which add a new one). We need to align the HTTP client to have the same options as gRPC has today.

I think you can replace the current HTTP approach:

quarkus.flow.http.client.workflow.order-flow.task.fetchCustomers.name=internal to be similar as gRPC quarkus.flow.http.client."org.acme:order-flow.fetchCustomers".name=internal. Probably it is a big change into our codebase (docs, examples if necessary, etc.)

@ricardozanini Do you agree with this change? If not we can follow the current HTTP configuration property, allowing namespace:name:task, namespace:name:version, namespace:name (versionless).

[ricardozanini]

No, you are correct. We need to align gRPC and HTTP to have ubiquity.

It's somewhat big, but must be done for 1.0.0 and throughout tested.

[mcruzdev]

No, you are correct. We need to align gRPC and HTTP to have ubiquity.

It's somewhat big, but must be done for 1.0.0 and throughout tested.

But @ricardozanini, my concerns are: should we use the same way as gRPC does today (using the full workflow ID + task name to define the route) or using as http does (using workflow."workflowname".task."task name")?

[matheusandre1]

I have that question too....

[ricardozanini]

I think I clearly said that all components MUST FOLLOW the SAME approach. Hence, full workflow ID wherever we used to use workflow name.

BUT, since just workflowName will be the most practical 99% of the cases (I really doubt someone will create, in the same application, same workflow names), we should keep BOTH on all extensions.

In short:

1. workflowName.taskName
2. workflowID.taskName

This way we also guarantee backward compatibility.

[mcruzdev]

Hey @matheusandre1, I think it is good, could you add a versionless here?

[ricardozanini]

You need to rebuild the docs:

Run STATUS=$(git status --porcelain docs/modules/ROOT/pages/includes/)
Generated documentation is not up to date.

The following generated files were changed or added and must be committed:

*  docs/modules/ROOT/pages/includes/quarkus-flow-grpc.adoc
*  docs/modules/ROOT/pages/includes/quarkus-flow-grpc_quarkus.flow.adoc

To fix this:
  1. Run: mvn clean install
  2. Commit the generated documentation files
Error: Process completed with exit code 1.

[ricardozanini]

@mcruzdev please take a look at the current main and docs. The OIDC module already has the algorithm for the property resolution. We need to align HTTP, OIDC, and gRPC before 1.0.0. Can you have a look and align everything, please?

[mcruzdev]

@mcruzdev please take a look at the current main and docs. The OIDC module already has the algorithm for the property resolution. We need to align HTTP, OIDC, and gRPC before 1.0.0. Can you have a look and align everything, please?

Yes, of course!

[ricardozanini]

@matheusandre1 @mcruzdev I think this can be closed since #821 is already implementing it?

[ricardozanini]

Let me know so I can reopen it.