Add cache-friendly qubit index remapping#1075
Open
xxie24 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces qubit remapping functionality (qubit_remap.h) to improve state-vector cache locality, adds a NEON-vectorized simulator (simulator_neon.h and statespace_neon.h), and updates the runner and build configurations to support these features. The code review identified critical issues in the new remapping logic, including a potential out-of-bounds memory access in RemapIndex, a logic bug in RemapMeasurementResult that corrupts measurement results by incorrectly rebuilding the bitstring, and undefined behavior in RemapControlQubits caused by shifting a boolean value by more than 31 bits.
2bd3c08 to
a48e67d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remap scores circuit qubits by gate usage, places frequently used qubits on lower physical state-index bits, and rewrites gates so simulation preserves the original logical circuit semantics. This improves memory locality for hot qubits during gate application.
Summary:
Benchmark note: