feat: refresh auth providers and score precision#196
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c491538085
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return 0; | ||
| } | ||
|
|
||
| return Math.round(numeric * 100) / 100; |
There was a problem hiding this comment.
Use half-up decimal rounding for scores
When value is a valid score such as 1.005 (which can be produced by redistribution ratios before persistence), binary floating-point makes numeric * 100 fall just below the half, so this returns 1 and formats 1.00; the backend scorer now persists totals with Decimal(..., ROUND_HALF_UP), so admin previews/UI formatting can disagree with saved totals by 0.01. Please use a backend-equivalent decimal/string rounding path here rather than raw Math.round on a float.
Useful? React with 👍 / 👎.
變更目標
影響範圍
驗證
風險與回滾