Skip to content

Enable markdown mode#48

Open
quambene wants to merge 4 commits into
mainfrom
enable-markdown-mode
Open

Enable markdown mode#48
quambene wants to merge 4 commits into
mainfrom
enable-markdown-mode

Conversation

@quambene

@quambene quambene commented Nov 16, 2023

Copy link
Copy Markdown
Owner

To enable markdown mode again, the following needs to be fixed:

  1. panics for bogrep <pattern> --mode markdown (cf. thread 'main' panicked #30) ✔️
  2. conversion from HTML to markdown is leading to >1 GB markdown files for a few urls (while plaintext files are still a few kilobytes)

@codecov

codecov Bot commented Nov 16, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.34%. Comparing base (0c9cd10) to head (5611298).
⚠️ Report is 84 commits behind head on main.

Files with missing lines Patch % Lines
src/cache.rs 0.00% 7 Missing ⚠️
src/cmd/search.rs 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   91.59%   91.34%   -0.25%     
==========================================
  Files          26       26              
  Lines        3401     3410       +9     
==========================================
  Hits         3115     3115              
- Misses        286      295       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@quambene quambene mentioned this pull request Nov 17, 2023
@mattmartini

Copy link
Copy Markdown

I just tried markdown mode and it still hangs after downloading some content.

@quambene

quambene commented Nov 17, 2023

Copy link
Copy Markdown
Owner Author

that's the second part (see description above) which is not fixed yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants