fix(install): soft-fail Cursor install so a missing asset can't kill the one-liner#20
Merged
Merged
Conversation
…the one-liner Cursor is auto-detected from ~/.cursor (present for nearly every developer), and cursor_install_plugin called `die` on download failure — so when the rogue-plugin-cursor.tar.gz release asset 404s (not yet published), the whole installer aborts AFTER the Claude/Codex installs, breaking the one-liner in prod. Make the Cursor path non-fatal: warn and continue (return 1 / catch) on download, extract, or manifest failure. Claude/Codex still install; Cursor is skipped with a clear "re-run once published" message. Mirrors in install.sh and install.ps1. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RLk1XJQ1uWYSdn5Ro31JHv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prod incident
The one-liner dies in prod:
Root cause: Cursor is auto-detected from
~/.cursor(present for nearly everydeveloper), and
cursor_install_plugincalleddieon download failure. Therogue-plugin-cursor.tar.gzrelease asset isn't published yet (latest release isv1.0.16, which predates the cursor work), so the download 404s and the wholeinstaller aborts — after Claude/Codex already installed — breaking the one-liner.
Fix (bleed-stop)
Make the Cursor path non-fatal: warn and continue (
return 1ininstall.sh,throw→catchininstall.ps1) on download / extract / manifest failure. Claudeand Codex still install; Cursor is skipped with a clear "re-run once published"
message and the script exits 0.
Verified: cursor-only run against the live 404 now warns and exits 0.
Still needed (separate, outward-facing)
This stops the breakage but Cursor won't actually install until a release publishes
rogue-plugin-cursor.tar.gzto/releases/latest/download/. That release is thereal fix and is a fleet-wide action (triggers Claude auto-update) — handled separately.
🤖 Generated with Claude Code
https://claude.ai/code/session_01RLk1XJQ1uWYSdn5Ro31JHv