[aarch64] Add configure flag to control the use of optimized memset/memcpy#12
Merged
Conversation
Signed-off-by: Zhaoshi Zheng <zhaoshiz@qti.qualcomm.com>
This patch adds bti landing pad for aarch64's assembly implementation of memset/memcpy when --quic-aarch64-mark-bti is passed during configure. Signed-off-by: Pengxuan Zheng <pzheng@qti.qualcomm.com>
…emcpy This patch adds a configure flag "--quic-aarch64-optmem" to optionally enable aarch64's assembly implementation of memset/memcpy. With this patch, the generic implementation is used by default and the optimized implementation is only used if the flag "--quic-aarch64-optmem" is passed explicitly when configuring. More specifically, with this patch, all aarch64 baremetal variants will use the generic version of memset/memcpy instead of the optimzed one. We only enable the optimized memset/memcpy for the aarch64 linux variant for now. Signed-off-by: Pengxuan Zheng <pzheng@qti.qualcomm.com>
pzhengqc
changed the title
Contributor
|
Thanks Pengxuan, LGTM |
| BUILTIN=clang_rt.builtins-pacret-bti-aarch64-nofp | ||
|
|
||
| ./configure --disable-wrapper --quic-arm-baremetal --quic-aarch64-nofp --disable-visibility CROSS_COMPILE="llvm-" CC="clang --target=aarch64-none-elf -fuse-ld=eld" CFLAGS="-mabi=aapcs-soft -march=armv8.5-a -mbranch-protection=pac-ret+leaf+b-key+bti -Os -mstrict-align -fPIC -fdata-sections -ffunction-sections -fvisibility=hidden -DVISIBILITY_HIDDEN -mgeneral-regs-only -mllvm -aarch64-enable-simd-scalar=false -fno-rounding-math" LDFLAGS="-Wl,-L${PATH_TO_BUILTIN}" LIBCC="-l${BUILTIN}" "$@" | ||
| ./configure --disable-wrapper --quic-arm-baremetal --quic-aarch64-nofp --quic-aarch64-mark-bti --disable-visibility CROSS_COMPILE="llvm-" CC="clang --target=aarch64-none-elf -fuse-ld=eld" CFLAGS="-mabi=aapcs-soft -march=armv8.5-a -mbranch-protection=pac-ret+leaf+b-key+bti -Os -mstrict-align -fPIC -fdata-sections -ffunction-sections -fvisibility=hidden -DVISIBILITY_HIDDEN -mgeneral-regs-only -mllvm -aarch64-enable-simd-scalar=false -fno-rounding-math" LDFLAGS="-Wl,-L${PATH_TO_BUILTIN}" LIBCC="-l${BUILTIN}" "$@" |
Contributor
There was a problem hiding this comment.
Confirmed with pzhengqc that if quic_aarch64_optmem is not specified, quic-aarch64-mark-bti is not needed. So we should clean this up. We can also enable the quic_aarch64_optmem for all linux configs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.