Allow out of tree builds#11
Merged
Merged
Conversation
Upstream musl (even the version musl-embedded is based on) seems to allow for out of tree builds. I think enabling this for musl-embedded is pretty straightforward--just making sure that we make paths source-relative and symlink our makefiles similar to what upstream does. This is primarly helpful for us in that it lets us build multiple variants without worrying about whether they are concurrent. Signed-off-by: Jonathon Penix <jpenix@quicinc.com>
Jonathon Penix (jonathonpenix)
requested review from
Ana Pazos (apazos) and
Zhaoshi Zheng (zhaoshiz)
Contributor
|
Thanks Jonathon Penix (@jonathonpenix), LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream musl (even the version musl-embedded is based on) seems to allow for out of tree builds. I think enabling this for musl-embedded is pretty straightforward--just making sure that we make paths source-relative and symlink our makefiles similar to what upstream does.
This is primarly helpful for us in that it lets us build multiple variants without worrying about whether they are concurrent.