[cpullvm] Split ninja check-* lines in test scripts.#449
Merged
Jonathon Penix (jonathonpenix) merged 2 commits intoJun 26, 2026
Merged
Conversation
`check-all-llvm-toolchain` runs *all* enabled tests, which we don't want while we're trying to ex: enable libcxxabi tests before libcxx tests. And, the libcxx tests should be fairly slow to run so we won't always want those. So, split `check-all-llvm-toolchain` into `check-all` and `check-llvm-toolchain`. For the tests we have enabled today, this should be NFC: * check-all covers all LLVM-ish projects + eld * check-llvm-toolchain covers picolibc + compiler-rt + multilib tests So, everything we have enabled is covered. Note that this isn't strictly necessary for test.ps1 at the moment since QEMU testing is disabled on Windows. But, I'm splitting this anyway just to make it clearer what our intention is if we ever get to QEMU on Windows. Signed-off-by: Jonathon Penix <jpenix@qti.qualcomm.com>
Jonathon Penix (jonathonpenix)
requested review from
Yethendra,
Ana Pazos (apazos),
Shreeyash Pandey (bojle) and
Pawan Nirpal (pawan-nirpal-031)
Contributor
Author
|
Shreeyash Pandey (@bojle) if this goes in I think you'll have to add |
Contributor
Author
Ana Pazos (apazos)
approved these changes
Jun 25, 2026
Ana Pazos (apazos)
approved these changes
Jun 26, 2026
Jonathon Penix (jonathonpenix)
merged commit 9d43f35
into
qualcomm:qualcomm-software
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check-all-llvm-toolchainruns all enabled tests, which we don't want while we're trying to ex: enable libcxxabi tests before libcxx tests. And, the libcxx tests should be fairly slow to run so we won't always want those.So, split
check-all-llvm-toolchainintocheck-allandcheck-llvm-toolchain.For the tests we have enabled today, this should be NFC:
So, everything we have enabled is covered.
Note that this isn't strictly necessary for test.ps1 at the moment since QEMU testing is disabled on Windows. But, I'm splitting this anyway just to make it clearer what our intention is if we ever get to QEMU on Windows.