[CPULLVM] Fix test infrastructure for libc++ testing#340
Conversation
|
Ana Pazos (@apazos) Garvit Gupta (@quic-garvgupt) Shreeyash Pandey (@bojle) Could you please review. The tests enablement PR #323 is getting intertwined with some of the pre-reqs and the same changes are also required for Shreeyash Pandey (@bojle) and I suspect Garvit Gupta (@quic-garvgupt) should also find these changes useful. So It's best we get these in first. |
Pawan Nirpal (pawan-nirpal-031)
requested a review
from Jonathon Penix (jonathonpenix)
|
Hi Pawan Nirpal (@pawan-nirpal-031), thanks for putting this up. I see that I need to enable 'ENABLE_CXX_TESTS' in all the variant json files (which your other PR does too), would that be a candidate for this PR aswell? |
I think not, that will be part of the tests enablement themselves, which I believe we should plan to address in their respective PRs, the idea here is some pre-reqs that are required for us to even start enabling rt-tests should be addressed. take this with a grain of salt, I maybe wrong here. Ana Pazos (@apazos) Jonathon Penix (@jonathonpenix) does this make sense? |
If these set of changes are needed for libcxx, libcxxabi and libunwind tests, then pls update the commit header to reflect that. rtlibs mostly imply only compiler-rt tests. Also, it will be worth to add in the commit message a brief desciption of the issues that were encountered and how they are fixed through these changes. |
There was a problem hiding this comment.
Pawan Nirpal (@pawan-nirpal-031), I believe Navaneeth resolved the issue with missing ROM files like efi-virtio.rom for QEMU runs, so this change is no longer needed. Please check with Navaneeth and Garvit.
There was a problem hiding this comment.
Sure Ana Pazos (@apazos) I will drop this.
There was a problem hiding this comment.
Garvit Gupta (@quic-garvgupt), can you please check if this is an issue in the builders or in your local buid.
There was a problem hiding this comment.
Do these actually need to be in the group? Doesn't seem like it should be needed, but might not matter much in the end.
There was a problem hiding this comment.
Pawan Nirpal (@pawan-nirpal-031), just add ' -Wl,--start-group', no further change needed.
Pawan Nirpal (pawan-nirpal-031)
changed the title
|
The failures seem unrelated to the changes. I've asked eld lead to take a look at the eld failure. The other failure seems to be some CI failure. |
There was a problem hiding this comment.
Garvit Gupta (@quic-garvgupt), can you please check if this is an issue in the builders or in your local buid.
There was a problem hiding this comment.
Pawan Nirpal (@pawan-nirpal-031) please remove this change, we do not need it.
There was a problem hiding this comment.
Pawan Nirpal (@pawan-nirpal-031) Move the qemu-related changes to its on PR.
There was a problem hiding this comment.
Pawan Nirpal (@pawan-nirpal-031) Remove this change, it is handled in a separate PR by Jonathon.
There was a problem hiding this comment.
Pawan Nirpal (@pawan-nirpal-031), just add ' -Wl,--start-group', no further change needed.
There was a problem hiding this comment.
Pawan Nirpal (@pawan-nirpal-031), QEMU stuff in separate patch.
There was a problem hiding this comment.
Pawan Nirpal (@pawan-nirpal-031), remove this change, it is addressed in a separate patch by Jonathon.
There was a problem hiding this comment.
Pawan Nirpal (@pawan-nirpal-031), please remove this change, not needed.
There was a problem hiding this comment.
Pawan Nirpal (@pawan-nirpal-031) Please remove this change.
There was a problem hiding this comment.
Pawan Nirpal (@pawan-nirpal-031) Please remove this change.
|
Also please Pawan Nirpal (@pawan-nirpal-031) update the commit message for fixing libc++ tests only, though some changes apply beyond it. |
Pawan Nirpal (pawan-nirpal-031)
changed the title
Pawan Nirpal (pawan-nirpal-031)
requested review from
Ana Pazos (apazos) and
Jonathon Penix (jonathonpenix)
Signed-off-by: Pawan Nirpal <pnirpal@qti.qualcomm.com>
Signed-off-by: Pawan Nirpal <pnirpal@qti.qualcomm.com>
Signed-off-by: Pawan Nirpal <pnirpal@qti.qualcomm.com>
Signed-off-by: Pawan Nirpal <pnirpal@qti.qualcomm.com>
Pawan Nirpal (pawan-nirpal-031)
force-pushed
the
qualcomm-software
branch
from
8a234af to
8af9cca
Compare
|
Ana Pazos (@apazos) we should be good for merge now? |
Ana Pazos (apazos)
merged commit 2d66e26
into
qualcomm:qualcomm-software
5 participants
These are some pre-requisites for enabling compile-rt/libcxx/libcxx-abi tests.
Signed-off-by: Pawan Nirpal pnirpal@qti.qualcomm.com