Add glibc-based openmp build.#247
Open
Eli Friedman (efriedma-quic) wants to merge 1 commit into
Open
Conversation
Eli Friedman (efriedma-quic)
requested review from
Ana Pazos (apazos) and
Jonathon Penix (jonathonpenix)
and removed request for
Jonathon Penix (jonathonpenix)
Eli Friedman (efriedma-quic)
force-pushed
the
openmp-glibc
branch
3 times, most recently
from
9ab027b to
9815bb9
Compare
This involves downloading a gcc toolchain, and building against it. While I was adding in downloads, I made some improvements to our download infrastructure: we now cache downloads, and use sha256sum to verify them. Signed-off-by: Eli Friedman <efriedma@qti.qualcomm.com>
Eli Friedman (efriedma-quic)
force-pushed
the
openmp-glibc
branch
from
9815bb9 to
50b1cb4
Compare
Jonathon Penix (jonathonpenix)
approved these changes
Mar 16, 2026
Jonathon Penix (jonathonpenix)
left a comment
Jonathon Penix (jonathonpenix)
left a comment
Contributor
There was a problem hiding this comment.
Thanks!
Two misc. thoughts:
- The caching is nice (and we need to do that for some other things like ccache I think)--I'm guessing we want to do this in our nightlies as well, but I don't mind if we do that separately.
- Right now all our Linux libraries are off-by-default, is that still fine for this?
Contributor
Author
They're enabled on the buildbot, which seems like the important thing? I don't think the default for local builds matters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This involves downloading a gcc toolchain, and building against it.
While I was adding in downloads, I made some improvements to our download infrastructure: we now cache downloads, and use sha256sum to verify them.