Add aarch64a_standalone baremetal runtime variant#230
Conversation
ea7f41e to
462e1ae
Compare
| { | ||
| "variant": "aarch64a_standalone", | ||
| "json": "aarch64a_standalone.json", | ||
| "flags": "--target=aarch64-unknown-none-elf -fmultilib-flag=standalone", |
There was a problem hiding this comment.
can you please explain what does this flag do?
There was a problem hiding this comment.
This is a multilib custom flag (https://clang.llvm.org/docs/Multilib.html#multilib-custom-flags) used only for multilib selection. We have already added a few other custom flag to help with multilib selection for variants like shadow call stack, multi-threading, etc.
| - Name: no-threads | ||
| - Name: threads | ||
| Default: threads | ||
| - Name: standalone |
There was a problem hiding this comment.
I think it might be worth making this more generic to accommodate the uselocks and uselocks/standalone variants.
Doesn't need to be exactly this, but so we can have something like:
- Name: musl-subvariant
Values:
- Name: standalone
- Name: uselocks
- Name: no-subvariant
Default: no-subvariant
(I don't necessarily mind if we do something like this when adding those either)
There was a problem hiding this comment.
Thanks for the suggestion. I've renamed according to your suggestion to accommodate other variants. I'll add an entry for uselock in a separate patch when adding the uselock variant.
This is to support the libc-standalone.a variant from musl-embedded. Signed-off-by: Pengxuan Zheng <pzheng@qti.qualcomm.com>
462e1ae to
f860b98
Compare
|
LGTM, thank you! |
|
pzhengqc, let's hold off on this patch. Might not have users for it anylonger. |
Ana Pazos (apazos)
left a comment
There was a problem hiding this comment.
Let's hold on from merging, no clear user of these variants.
This is to support the libc-standalone.a variant from musl-embedded.