FROMLIST: misc: fastrpc: fix use-after-free of fastrpc_user in workqueue context#594
FROMLIST: misc: fastrpc: fix use-after-free of fastrpc_user in workqueue context#594quic-anane wants to merge 2 commits into
Conversation
…ser structure" This reverts commit 14e526a. This change corresponds to the initial (v1) version shared with the upstream community. Revert it to apply the complete v4 revision, which includes additional fixes and updates not present in the earlier version. v4 version contains this changes as well.
…eue context
There is a race between fastrpc_device_release() and the workqueue
that processes DSP responses. When the user closes the file descriptor,
fastrpc_device_release() frees the fastrpc_user structure. Concurrently,
an in-flight DSP invocation can complete and fastrpc_rpmsg_callback()
schedules context cleanup via schedule_work(&ctx->put_work). If the
workqueue runs fastrpc_context_free() in parallel with or after
fastrpc_device_release() has freed the user structure, it dereferences
the freed fastrpc_user. Depending on the state of the context at the
time of the race, any one of the following accesses can be hit:
1. fastrpc_buf_free() calls fastrpc_ipa_to_dma_addr(buf->fl->cctx, ...)
to strip the SID bits from the stored IOVA before passing the
physical address to dma_free_coherent().
2. fastrpc_free_map() reads map->fl->cctx->vmperms[0].vmid to
reconstruct the source permission bitmask needed for the
qcom_scm_assign_mem() call that returns memory from the DSP VM
back to HLOS.
3. fastrpc_free_map() acquires map->fl->lock to safely remove the
map node from the fl->maps list.
The resulting use-after-free manifests as:
pc : fastrpc_buf_free+0x38/0x80 [fastrpc]
lr : fastrpc_context_free+0xa8/0x1b0 [fastrpc]
fastrpc_context_free+0xa8/0x1b0 [fastrpc]
fastrpc_context_put_wq+0x78/0xa0 [fastrpc]
process_one_work+0x180/0x450
worker_thread+0x26c/0x388
Add kref-based reference counting to fastrpc_user. Have each invoke
context take a reference on the user at allocation time and release it
when the context is freed. Release the initial reference in
fastrpc_device_release() at file close. Move the teardown of the user
structure — freeing pending contexts, maps, mmaps, and the channel
context reference — into the kref release callback fastrpc_user_free(),
so that it runs only when the last reference is dropped, regardless of
whether that happens at device close or after the final in-flight
context completes.
Link:https://lore.kernel.org/all/20260518203507.3754994-1-anandu.e@oss.qualcomm.com/
Fixes: 6cffd79 ("misc: fastrpc: Add support for dmabuf exporter")
Cc: stable@kernel.org
Signed-off-by: Anandu Krishnan E <anandu.e@oss.qualcomm.com>
|
Merge Check Failed: CR Not Eligible for Merge CR 4502232 is not eligible for merge. The parent software image for kernel.qli.2.0 is not development complete. Entity: Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations. |
Test Matrix
|
LAVA Failed Case Triage SummaryPR: #594 Job 101881 | SoC qcs9100-rideLAVA job: https://lava-oss.qualcomm.com/scheduler/job/101881 Failed test cases in LAVA job 101881 (SoC: qcs9100-ride).
Job 101883 | SoC qcs8300-rideLAVA job: https://lava-oss.qualcomm.com/scheduler/job/101883 Failed test cases in LAVA job 101883 (SoC: qcs8300-ride).
Job 101885 | SoC qcs6490-rb3gen2LAVA job: https://lava-oss.qualcomm.com/scheduler/job/101885 Failed test cases in LAVA job 101885 (SoC: qcs6490-rb3gen2).
Job 101886 | SoC x1e80100LAVA job: https://lava-oss.qualcomm.com/scheduler/job/101886 Failed test cases in LAVA job 101886 (SoC: x1e80100).
Job 101887 | SoC monaco-evkLAVA job: https://lava-oss.qualcomm.com/scheduler/job/101887 Failed test cases in LAVA job 101887 (SoC: monaco-evk).
Job 101888 | SoC qcs615-rideLAVA job: https://lava-oss.qualcomm.com/scheduler/job/101888 Failed test cases in LAVA job 101888 (SoC: qcs615-ride).
Job 101889 | SoC lemans-evkLAVA job: https://lava-oss.qualcomm.com/scheduler/job/101889 Failed test cases in LAVA job 101889 (SoC: lemans-evk).
|
|
Merge Check Failed: CR Not Eligible for Merge CR 4502232 is not eligible for merge. The parent software image for kernel.qli.2.0 is not development complete. Entity: Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations. |
Changes in this PR
This PR contains two commits:
Revert previous patch
Reverts the earlier fastrpc_user reference counting change.
This is done to avoid carrying forward a partially updated
implementation and to ensure a clean base.
Apply latest patch (v4) from mailing list
Applies the full, updated version of the fix.
Incorporates all revisions from earlier versions.
Ensures correct ordering of:
fastrpc_user_put()
fastrpc_channel_ctx_put()
Consolidates teardown logic into fastrpc_user_free().
Fixes use-after-free scenarios in workqueue and error paths.
CRs-Fixed: 4502232