Bluetooth: hci_qca: Convert timeout from jiffies to ms#578
Conversation
shashim-quic
left a comment
There was a problem hiding this comment.
- Prefix appropriate tag in subject
- add Link: in commit log
a86d5eb to
25663b9
Compare
Since the timer uses jiffies as its unit rather than ms, the timeout value must be converted from ms to jiffies when configuring the timer. Otherwise, the intended 8s timeout is incorrectly set to approximately 33s. To improve readability, embed msecs_to_jiffies() directly in the macro definitions and drop the _MS suffix from macros that now yield jiffies values: MEMDUMP_TIMEOUT, FW_DOWNLOAD_TIMEOUT, IBS_DISABLE_SSR_TIMEOUT, CMD_TRANS_TIMEOUT, and IBS_BTSOC_TX_IDLE_TIMEOUT. IBS_WAKE_RETRANS_TIMEOUT_MS and IBS_HOST_TX_IDLE_TIMEOUT_MS are intentionally left unchanged. Their values are stored in the struct fields wake_retrans and tx_idle_delay, which hold ms values at runtime and can be modified via debugfs. The msecs_to_jiffies() conversion happens at each call site against the field value, so it cannot be embedded in the macro. Wake timer depends on commit c347ca1 Link: https://lore.kernel.org/all/20260511135837.3967550-1-shuai.zhang@oss.qualcomm.com/ Cc: stable@vger.kernel.org Fixes: d841502 ("Bluetooth: hci_qca: Collect controller memory dump during SSR") Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Signed-off-by: Shuai Zhang <shuai.zhang@oss.qualcomm.com>
25663b9 to
88e0d7b
Compare
PR #578 — validate-patchPR: #578
|
PR #578 — checker-log-analyzerPR: #578
Detailed report: Full report
|
Test Matrix
|
LAVA Failed Case Triage SummaryPR: #578 Job 101896 | SoC qcs615-rideLAVA job: https://lava-oss.qualcomm.com/scheduler/job/101896 Failed test cases in LAVA job 101896 (SoC: qcs615-ride).
Job 101897 | SoC qcs9100-rideLAVA job: https://lava-oss.qualcomm.com/scheduler/job/101897 Failed test cases in LAVA job 101897 (SoC: qcs9100-ride).
Job 101898 | SoC x1e80100LAVA job: https://lava-oss.qualcomm.com/scheduler/job/101898 Failed test cases in LAVA job 101898 (SoC: x1e80100).
Job 101899 | SoC qcs6490-rb3gen2LAVA job: https://lava-oss.qualcomm.com/scheduler/job/101899 Failed test cases in LAVA job 101899 (SoC: qcs6490-rb3gen2).
Job 101900 | SoC lemans-evkLAVA job: https://lava-oss.qualcomm.com/scheduler/job/101900 Failed test cases in LAVA job 101900 (SoC: lemans-evk).
Job 101901 | SoC monaco-evkLAVA job: https://lava-oss.qualcomm.com/scheduler/job/101901 Failed test cases in LAVA job 101901 (SoC: monaco-evk).
Job 101902 | SoC qcs8300-rideLAVA job: https://lava-oss.qualcomm.com/scheduler/job/101902 Failed test cases in LAVA job 101902 (SoC: qcs8300-ride).
|
Since the timer uses jiffies as its unit rather than ms, the timeout value must be converted from ms to jiffies when configuring the timer. Otherwise, the intended 8s timeout is incorrectly set to approximately 33s.
To improve readability, embed msecs_to_jiffies() directly in the macro definitions and drop the _MS suffix from macros that now yield jiffies values: MEMDUMP_TIMEOUT, FW_DOWNLOAD_TIMEOUT, IBS_DISABLE_SSR_TIMEOUT, CMD_TRANS_TIMEOUT, and IBS_BTSOC_TX_IDLE_TIMEOUT.
IBS_WAKE_RETRANS_TIMEOUT_MS and IBS_HOST_TX_IDLE_TIMEOUT_MS are intentionally left unchanged. Their values are stored in the struct fields wake_retrans and tx_idle_delay, which hold ms values at runtime and can be modified via debugfs. The msecs_to_jiffies() conversion happens at each call site against the field value, so it cannot be embedded in the macro.
Wake timer depends on commit c347ca1
Link: https://lore.kernel.org/all/20260511135837.3967550-1-shuai.zhang@oss.qualcomm.com/
Cc: stable@vger.kernel.org
Fixes: d841502 ("Bluetooth: hci_qca: Collect controller memory dump during SSR")
Reviewed-by: Paul Menzel pmenzel@molgen.mpg.de
Acked-by: Bartosz Golaszewski bartosz.golaszewski@linaro.org
CRs-Fixed: 4498534