Skip to content

[6489][RM] cetmix_tower_server - #53

Merged
yostashiro merged 2 commits into
16.0from
6489-rm-cetmix_tower_server
Apr 2, 2026
Merged

[6489][RM] cetmix_tower_server#53
yostashiro merged 2 commits into
16.0from
6489-rm-cetmix_tower_server

Conversation

@smorita7749

Copy link
Copy Markdown
Contributor

@yostashiro

Copy link
Copy Markdown
Member

@AungKoKoLin1997 Can you please check if we should put .void outside the pre-commit scope? I'm wondering whether we should simply drop the practice of moving deprecated modules to the .void directory if the dotfile update operation would require an extra step.

@AungKoKoLin1997

Copy link
Copy Markdown
Contributor

Can you please check if we should put .void outside the pre-commit scope?

@yostashiro For most of our repos, I don't think we should do it because custom modules are created by us and handled pre-commit. So, there is no issue even we added to .void later. But we excluded this module when we added to this repo and we must exclude .void because of that. Then, I believe we should clean the code and fix pre-commit when we need to add other custom modules that are not created by us in the future. So, I think excluding .void is unnecessary.
#54

@yostashiro

Copy link
Copy Markdown
Member

@smorita7749 Please rebase your branch to the latest 16.0 code.

@smorita7749
smorita7749 force-pushed the 6489-rm-cetmix_tower_server branch from 28876af to 61cf2f7 Compare March 26, 2026 02:23
@nobuQuartile

Copy link
Copy Markdown
Contributor

@smorita7749
Could you remove paramiko from the requirements.txt?
The error is from it.

@smorita7749

Copy link
Copy Markdown
Contributor Author

@smorita7749 Could you remove paramiko from the requirements.txt? The error is from it.

It seems to be all good after removing paramiko from requirements.txt.

@yostashiro yostashiro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yostashiro
yostashiro merged commit 9ea5076 into 16.0 Apr 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants