Skip to content
This repository was archived by the owner on Mar 5, 2026. It is now read-only.

Ensure CCW orientation for indicator segments#399

Merged
qqrm merged 1 commit into
mainfrom
codex/fix-vertex-order-in-create_indicator_line_vertices
Sep 18, 2025
Merged

Ensure CCW orientation for indicator segments#399
qqrm merged 1 commit into
mainfrom
codex/fix-vertex-order-in-create_indicator_line_vertices

Conversation

@qqrm

@qqrm qqrm commented Sep 18, 2025

Copy link
Copy Markdown
Owner

Summary

  • reorder indicator line triangle vertices so every segment is emitted counter-clockwise F:src/infrastructure/rendering/gpu_structures.rs#L513-L520
  • add a wasm-bindgen test asserting positive pseudo-cross products for a horizontal indicator segment F:tests/indicator_vertices.rs#L27-L39

Testing

  • cargo fmt --all
  • cargo check --tests --benches
  • cargo clippy --tests --benches --fix --allow-dirty -- -D warnings
  • cargo test (fails: wasm-bindgen UI tests panic because DOM elements are missing in the headless runner)

https://chatgpt.com/codex/tasks/task_e_68cb8a55ee3483329c732bf45094feee

@qqrm qqrm merged commit 75f6cc9 into main Sep 18, 2025
2 of 4 checks passed
@qqrm qqrm deleted the codex/fix-vertex-order-in-create_indicator_line_vertices branch September 18, 2025 04:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant