Preserve phrase buffer after word conversion#130
Merged
Conversation
ff822c4 to
1a93d45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the full last-phrase journal sequence after a last-word conversion, and add regression coverage for the double-Shift then double-Alt path.
Problem
After converting only the last word, the journal ended with a programmatic run. Last-sequence extraction preferred that programmatic tail and therefore double-Alt could target only the last word instead of the whole phrase.
Solution
Add a unified last-sequence extractor that keeps a contiguous physical phrase prefix when it is followed by a programmatic tail from word conversion. When converting such mixed-origin sequences, already-programmatic text is preserved so the fixed word is not toggled back while the physical prefix is converted.
Scope
Includes input journal extraction, last-sequence conversion behavior, and regression tests for phrase buffer preservation. Does not change hotkey bindings or selection probing.
Validation
Risks
Manual interactive verification in a live target app was not performed in this session; behavior is covered at journal/conversion level.