[Aikido] Fix 4 security issues in markdown-it, dompurify#594
Open
aikido-autofix[bot] wants to merge 3 commits into
Open
[Aikido] Fix 4 security issues in markdown-it, dompurify#594aikido-autofix[bot] wants to merge 3 commits into
aikido-autofix[bot] wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade markdown-it and dompurify to fix DoS via quadratic smartquotes parsing and template injection vulnerabilities in DOM sanitization.
✅ There are no breaking changes
✅ 4 CVEs resolved by this upgrade
This PR will resolve the following CVEs:
replaceAt()function.clearConfig()calls, allowing a malicious or unsafe policy set by one caller to be used by a later caller requestingRETURN_TRUSTED_TYPE, resulting in XSS execution at Trusted Types sinks. This affects applications that reuse DOMPurify across trust boundaries without proper state isolation.When DOMPurify is configured with
SAFE_FOR_TEMPLATES: trueand DOM return modes (RETURN_DOM,IN_PLACE), attackers can inject template expressions like${evil}or{{evil}}inside<template>elements by splitting them across removed elements, bypassing sanitization and enabling template injection or XSS. The string output path is unaffected.