Fix kak#1078
Merged
Merged
Conversation
Add a Success field to the Messages struct and provide translations for en_US, zh_CN and ja_JP so the success label is localizable. Update the preset copy button handler in settings.go to use msgr.Success (localized) instead of a hardcoded "success" string and keep the color argument (ColorSuccess). This centralizes the success message for i18n and ensures consistency across UI messages.
Reset listing dialog minHeight before re-locking to offsetHeight to avoid flicker and handle missing element safely (presets/listing_builder.go). Replace the VAutocomplete schedule control with a compact VBtn (icons, flat variant, density, height and class tweaks) to improve appearance and interaction, and adjust related classes/attributes (publish/version_compo.go). Also normalize dialog width string from "900px" to "900" for the listing builder configuration.
Update go.mod to require github.com/qor5/x/v3 at pseudo-version v3.2.1-0.20260522031431-46d6ad4cfc7e and regenerate go.sum to include the new module checksums. No other source changes.
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Go |  |
May 22, 2026 4:10a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
- GO-W1004: set SkipDefaultTransaction:true on the test-only gorm.Config in pagebuilder_test.go; the implicit transaction wrapping is unnecessary for the plain test connection. - GO-W5003: introduce a typed modelBuilderCtxKey instead of using bare string as the context key for *ModelBuilder lookups. Updated ContextValueProvider, the publish-side reader, and the publish_test.go inline producer to use it. - GO-R1005: silence the cyclomatic-complexity finding on TestPageBuilder via //skipcq. The 62 complexity comes from ~70 inline ReqFunc closures in a table-driven test; extracting them wouldn't reduce control-flow complexity meaningfully and would obscure the test data layout. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ia skipcq The previous attempt to fix DeepSource GO-W5003 by introducing modelBuilderCtxKey in pagebuilder/model.go broke the cross-package context-key contract: publish package (and microsite, l10n) still read context.Value with utils.GetObjectName() as a plain string, so PublishUrl's lookup returned nil and TestPageBuilderCampaign sub-tests for publish/unpublish failed in CI. Restore the plain-string key on the producer (ContextValueProvider) and reader (PublishUrl) sides and annotate the test line that DeepSource flagged with a //skipcq:GO-W5003 directive. A clean typed-key fix requires coordinated changes across pagebuilder, publish, microsite, and l10n and is out of scope for this PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…uppressed Per review feedback: don't suppress DeepSource findings with //skipcq when we can't (or won't) cleanly fix them in this PR. The two remaining findings are: - GO-R1005 (cyclomatic complexity 62 on TestPageBuilder): the function is a 72-case table-driven test with inline ReqFunc closures; extracting them to helpers would just move the complexity, not reduce it. - GO-W5003 (string as ctx key in publish_test.go:47): pagebuilder writes and publish reads via a plain-string key today; switching to a typed key needs coordinated changes across pagebuilder, publish, microsite, and l10n. Leaving these for follow-up. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
molon
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.