Fix: remove redundant OpenRead preflight for audio download - #12
Merged
Conversation
- Replace the OpenRead()+Close() URL check with a single DownloadFile call. - Catch WebException with 404 to skip missing audio files cleanly. - Add a User-Agent header to avoid being blocked by CDN/server.
GinForGit
force-pushed
the
fix/audio-network-preflight
branch
from
July 12, 2026 09:54
41c7163 to
817b999
Compare
qew21
self-requested a review
July 12, 2026 10:52
qew21
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PlayAudioFromUrlcurrently callswebClient.OpenRead(url).Close()before the actualDownloadFile. This is a GET request that is discarded immediately, so every audio triggers two HTTP requests instead of one. The endpoint also returns405 Method Not Allowedfor HEAD, so the preflight is not a cheap HEAD check.Solution
OpenReadpreflight.WebClient.DownloadFile.WebExceptionwith status404to skip missing audio files cleanly.User-Agentheader to avoid being blocked by CDN/server.Note
This branch is based on #11 and will show only the network fix once #11 is merged.
Testing
User-Agentand returns404for unknown md5.