fix(local): preserve datatype for created dense vectors#1206
fix(local): preserve datatype for created dense vectors#1206pragnyanramtha wants to merge 2 commits into
Conversation
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR adds datatype parameter preservation to dense vector configuration in local collections. The implementation change in Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hey @pragnyanramtha Thanks for your interest in qdrant-client! We don't utilise datatype in local mode, so preserving it might cause some confusion. A branch can point master only if it is a hotfix requiring a merge before |
916ddbd to
178dda7
Compare
|
Thanks for the review, @joein. I retargeted this PR to I also tightened the PR description and test name to clarify the scope: this does not make local mode use Validation run on the rebased branch:
|
Summary
DenseVectorConfig.datatypein collection metadata when local mode creates a dense named vectorfloat32and does not apply storage datatypesget_collection()metadata aftercreate_vector_name()Validation
.venv/bin/python -m pytest tests/test_in_memory.py::test_create_vector_name_preserves_dense_datatype_in_collection_metadata -q.venv/bin/python -m pytest tests/test_in_memory.py -q.venv/bin/python -m pytest tests/test_local_persistence.py -q.venv/bin/ruff check qdrant_client/local/local_collection.py tests/test_in_memory.pygit diff --check