Avoid ONNX session load for token counts#640
Draft
Mirochill wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
New Feature Submissions:
pre-commitwithpip3 install pre-commitand set up hooks withpre-commit install?Summary
Fixes #584.
This updates lazy
token_count()paths so they load tokenizer files from the resolved model directory without initializing ONNX sessions. The change covers text embeddings, cross-encoder rerankers, sparse BM42, late-interaction embeddings, and multimodal late-interaction wrappers.The lazy-load regression tests now exercise
token_count()before embedding/reranking and still assert that the ONNX model session has not been loaded yet.Validation
git diff --checkgit diff --cached --checkgit show --check --stat --oneline HEADtoken_count()paths for remaining ONNX-session loading calls