Skip to content

PoC: log Tier-B visibility cache hit rate #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Elton Carreiro (EltonCarreiro) wants to merge 1 commit into from
+33 −2
Closed

PoC: log Tier-B visibility cache hit rate #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 33 additions & 2 deletions WebDriverAgentLib/Categories/XCUIElement+FBIsVisible.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@

#import "XCUIElement+FBIsVisible.h"

#import <stdatomic.h>

#import "FBElementUtils.h"
#import "FBLogger.h"
#import "FBXCodeCompatibility.h"
#import "FBXCElementSnapshotWrapper+Helpers.h"
#import "XCUIElement+FBUtilities.h"
Expand Down Expand Up @@ -36,12 +39,40 @@ @implementation FBXCElementSnapshotWrapper (FBIsVisible)

- (BOOL)fb_hasVisibleDescendants
{
// PoC (poc/log-tier-b-cache-hits): observability-only. Instrument the Tier B
// short-circuit so we can measure how often it actually fires vs falls
// through to the Tier C synchronous AX-framework IPC. Counters are
// process-wide and accumulate across requests; logging every 50 calls keeps
// the output volume tractable on dense screens (500+ nodes per /source).
// No behaviour change — this PR only adds the log line.
static _Atomic NSUInteger fbVisCacheTierBCalls = 0;
static _Atomic NSUInteger fbVisCacheTierBHits = 0;

NSUInteger descendantsWalked = 0;
BOOL hit = NO;
for (id<FBXCElementSnapshot> descendant in (self._allDescendants ?: @[])) {
descendantsWalked++;
if ([fetchSnapshotVisibility(descendant) boolValue]) {
return YES;
hit = YES;
break;
}
}
return NO;

NSUInteger calls = atomic_fetch_add(&fbVisCacheTierBCalls, 1) + 1;
if (hit) {
atomic_fetch_add(&fbVisCacheTierBHits, 1);
}
if (0 == (calls % 50)) {
NSUInteger hits = atomic_load(&fbVisCacheTierBHits);
double hitRate = 100.0 * (double)hits / (double)calls;
[FBLogger logFmt:@"[VisCache] Tier-B stats: calls=%lu hits=%lu (%.1f%%) lastWalked=%lu lastResult=%@",
(unsigned long)calls,
(unsigned long)hits,
hitRate,
(unsigned long)descendantsWalked,
hit ? @"YES" : @"NO"];
}
return hit;
}

- (BOOL)fb_isVisible
Expand Down