Skip to content

Remove unused public hamburg renewal token parser#9

Merged
molikuner merged 1 commit into
mainfrom
cleanup/GH-2-remove-warnings
Jun 8, 2025
Merged

Remove unused public hamburg renewal token parser#9
molikuner merged 1 commit into
mainfrom
cleanup/GH-2-remove-warnings

Conversation

@molikuner

Copy link
Copy Markdown
Collaborator

Since we're using the same token for login as for renewal, this code isn't used anymore and creates build warnings. This PR removes it.

I've locally also some changes to fix some cargo clippy warnings. It might create a few merge conflicts with #8 though, so I would prefer to apply them only after that PR is merged.

Closes #2

@molikuner
molikuner requested a review from q231950 June 8, 2025 04:15
Comment thread paper/src/model/renewal/renewal_token_parser.rs

@q231950 q231950 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah cool, was doing the same in the "recommender" branch but having it separately is better 👍 thank you!

@molikuner
molikuner merged commit 33fc389 into main Jun 8, 2025
1 check passed
@molikuner
molikuner deleted the cleanup/GH-2-remove-warnings branch June 8, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup warnings

2 participants