Skip to content

Remove extra runtime created when renewing Hamburg items#10

Merged
molikuner merged 1 commit into
mainfrom
fix/hamburg-renewal-still-creates-extra-runtime
Jun 14, 2025
Merged

Remove extra runtime created when renewing Hamburg items#10
molikuner merged 1 commit into
mainfrom
fix/hamburg-renewal-still-creates-extra-runtime

Conversation

@molikuner

Copy link
Copy Markdown
Collaborator

Looks like I missed that one in #8. Should be also removed though.

@molikuner
molikuner requested a review from q231950 June 13, 2025 18:22
@q231950

q231950 commented Jun 13, 2025

Copy link
Copy Markdown
Owner

Thanks @molikuner, eagle eye 😉 I had checked renewal with Hamburg public library and it had worked. Looking at this I would assume it should have failed? Not sure. Anyways, good catch! I'll give it a spin in test flight once again, I'll let you know about the result.

@q231950 q231950 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Just checked renewal and refresh and it's all fine. Thanks @molikuner 💯

@molikuner

Copy link
Copy Markdown
Collaborator Author

Yeah, I would also have thought the renewal should have failed before, but I'm glad it still works 😄

@molikuner
molikuner merged commit 18a0b01 into main Jun 14, 2025
1 check passed
@molikuner
molikuner deleted the fix/hamburg-renewal-still-creates-extra-runtime branch June 14, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants