Use Paper's List of Supported Libraries#22
Open
q231950 wants to merge 2 commits into
Open
Conversation
Remove Libraries.plist in favor of centralized library management in the Paper framework. The Paper framework now serves as the single source of truth for library configurations. Key changes: - Remove Libraries.plist and associated plist parsing logic - Add LibraryModelProvider protocol for dependency injection - Create LibraryList wrapper around Paper's library management - Simplify LibraryModel by removing baseURL and catalogUrl fields - Update all use cases to fetch libraries from Paper.LibraryList() - Fix typo: depenency → dependency 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Replace hardcoded library availability logic with flags from Paper.Library. This delegates library configuration to the Paper framework and removes the need to maintain exclusion lists in the app. Changes: - Add enabledForSearch and enabledForLogin to Library protocol - Remove isAvailable and isAvailableForLogin computed properties - Update InternalLibraryModel to map flags from Paper.Library - Update LibraryModel with new properties (default: true) - Update LibrarySelectionViewModel to use new property names - Update all test stubs and mocks - Add Core Data migration (v28→v29) for new library attributes - Update LibraryManager to persist new flags 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
q231950
marked this pull request as ready for review
January 18, 2026 14:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes Hamburg Public library from list of supported libraries. Besides that performs some refactoring around the supported libraries list. This pr goes hand in hand with q231950/paper#16.
Summary
enabledForSearchandenabledForLoginflags from PaperLibraryModelProviderprotocol for dependency injectionChanges
Library Configuration Centralization
Library Model Simplification
baseURLandcatalogUrlfrom LibraryModel (now managed by Paper)enabledForSearchandenabledForLoginproperties to Library protocolAPI Configuration
🤖 Generated with https://claude.com/claude-code