UI Enhancements#18
Draft
q231950 wants to merge 5 commits into
Draft
Conversation
q231950
marked this pull request as ready for review
September 28, 2025 10:56
molikuner
approved these changes
Oct 3, 2025
Comment on lines
+65
to
+66
| .accessibilityLabel("delete bookmark button") | ||
| .confirmationDialog("Are you sure you want to delete the bookmark?", isPresented: $viewModel.showsDeleteConfirmation) { |
Collaborator
There was a problem hiding this comment.
Do we need to translate those strings, or are they somehow translated by the ToolbarItem itself?
Owner
Author
There was a problem hiding this comment.
I quickly searched for Are you sure you want to delete the bookmark? and couldn't find it anywhere. I will check this, could be that I forgot to localize it. There is no auto-magical-localization, but it's possible to localize it:
Owner
Author
There was a problem hiding this comment.
Pretty sure it's not localized. I'll add the key here once #21 got merged. Good catch @molikuner!
q231950
marked this pull request as draft
October 4, 2025 19:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.