Skip to content

WMO Instruments Part 3: Rename enhancement/composite YAML files#3420

Closed
sfinkens wants to merge 96 commits into
pytroll:mainfrom
sfinkens:wmo-instruments-part3-rename
Closed

WMO Instruments Part 3: Rename enhancement/composite YAML files#3420
sfinkens wants to merge 96 commits into
pytroll:mainfrom
sfinkens:wmo-instruments-part3-rename

Conversation

@sfinkens

Copy link
Copy Markdown
Member

Rename enhancement/composite YAML files so that they follow the WMO instrument naming convention. To be merged into #3390 .

Composites

The following composite files were renamed

insat3d_img -> imager_insat
vii         -> metimage
ec_msi      -> msi
msu-gsa     -> msu-gs-a
virr        -> virr_fy-3
sar-c       -> sar-c_sentinel-1
sen2_msi    -> msi_sentinel-2a

The following composite files are new and only load the corresponding shared composite.

imager_goes_8-11  -> goes_imager
imager_goes_12-15 -> goes_imager
mwr_aws           -> mwr
mwr_sterna        -> mwr
oli               -> oli_tirs
tirs              -> oli_tirs

Enhancements

The following enhancement files were renamed:

sen2_msi -> msi

The following symbolic links are new and only point to the shared enhancement (there is no mechanism like the dependency tree for enhancements)

mrw_sterna.yaml -> mwr.yaml
mwr_aws.yaml    -> mwr.yaml

Compatibility

Also search for user-defined composites and enhancements with the old instrument name. If present, display a deprecation warning asking users to rename their files.

sfinkens and others added 30 commits May 4, 2026 11:51
Co-authored-by: David Hoese <david.hoese@ssec.wisc.edu>
@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.31664% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.42%. Comparing base (1adb2fa) to head (262d5fe).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
satpy/enhancements/enhancer.py 92.85% 2 Missing ⚠️
satpy/readers/core/yaml_reader.py 80.00% 2 Missing ⚠️
satpy/readers/ghrsst_l3c_sst.py 0.00% 2 Missing ⚠️
satpy/readers/maia.py 33.33% 2 Missing ⚠️
satpy/decision_tree.py 90.90% 1 Missing ⚠️
satpy/readers/mirs.py 88.88% 1 Missing ⚠️
satpy/readers/nucaps.py 75.00% 1 Missing ⚠️
satpy/readers/scmi.py 75.00% 1 Missing ⚠️
satpy/readers/seviri_l1b_icare.py 66.66% 1 Missing ⚠️
satpy/readers/tropomi_l2.py 66.66% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3420      +/-   ##
==========================================
+ Coverage   96.33%   96.42%   +0.08%     
==========================================
  Files         467      467              
  Lines       59138    59325     +187     
==========================================
+ Hits        56973    57205     +232     
+ Misses       2165     2120      -45     
Flag Coverage Δ
behaviourtests ?
unittests 96.42% <97.31%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant