ios: drop deprecated MPS export step from both iOS scripts#19303
ios: drop deprecated MPS export step from both iOS scripts#19303rascani wants to merge 1 commit intopytorch:mainfrom
Conversation
The iOS demo's `testV3WithMPSBackend` was removed in meta-pytorch/executorch-examples (companion change), since the MPS backend is deprecated for removal in ExecuTorch 1.4 (pytorch#18425) and the test had been intermittently failing on the macos-14-xlarge runner pool on what looks like fp16 numerical drift rather than an executorch regression — the MPS runtime in pytorch/executorch hasn't materially changed since the deprecation. Remove the matching `mps_example.py` export step from the two iOS demo build scripts (the CI variant `.ci/scripts/test_ios_ci.sh` and the developer-facing `scripts/test_ios.sh`) so neither produces an `.pte` that nothing consumes. Out of scope here: the demo app's MPS enum case and `mv3_mps_float16.pte` artifact in the executorch-examples build workflow — those want their own follow-up cleanup once MPS is fully removed in 1.4. Authored with Claude Code.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19303
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Awaiting Approval, 3 New Failures, 1 Pending, 7 Unrelated FailuresAs of commit e0b6adb with merge base 08b2987 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
Summary
The iOS demo's
testV3WithMPSBackendwas removed in meta-pytorch/executorch-examples (#238), since the MPS backend is deprecated for removal in ExecuTorch 1.4 (#18425) and the test had been intermittently failing on the macos-14-xlarge runner pool on what looks like fp16 numerical drift rather than an executorch regression — the MPS runtime in pytorch/executorch hasn't materially changed since the deprecation.Remove the matching
mps_example.pyexport step from the two iOS demo build scripts (the CI variant.ci/scripts/test_ios_ci.shand the developer-facingscripts/test_ios.sh) so neither produces an.ptethat nothing consumes. Out of scope here: the demo app's MPS enum case andmv3_mps_float16.pteartifact in the executorch-examples build workflow — those want their own follow-up cleanup once MPS is fully removed in 1.4.Authored with Claude Code.
Test plan
CI