Skip to content

ios: drop deprecated MPS export step from both iOS scripts#19303

Draft
rascani wants to merge 1 commit intopytorch:mainfrom
rascani:drop-mps-from-ios-ci-export
Draft

ios: drop deprecated MPS export step from both iOS scripts#19303
rascani wants to merge 1 commit intopytorch:mainfrom
rascani:drop-mps-from-ios-ci-export

Conversation

@rascani
Copy link
Copy Markdown
Contributor

@rascani rascani commented May 5, 2026

Summary

The iOS demo's testV3WithMPSBackend was removed in meta-pytorch/executorch-examples (#238), since the MPS backend is deprecated for removal in ExecuTorch 1.4 (#18425) and the test had been intermittently failing on the macos-14-xlarge runner pool on what looks like fp16 numerical drift rather than an executorch regression — the MPS runtime in pytorch/executorch hasn't materially changed since the deprecation.

Remove the matching mps_example.py export step from the two iOS demo build scripts (the CI variant .ci/scripts/test_ios_ci.sh and the developer-facing scripts/test_ios.sh) so neither produces an .pte that nothing consumes. Out of scope here: the demo app's MPS enum case and mv3_mps_float16.pte artifact in the executorch-examples build workflow — those want their own follow-up cleanup once MPS is fully removed in 1.4.

Authored with Claude Code.

Test plan

CI

The iOS demo's `testV3WithMPSBackend` was removed in
meta-pytorch/executorch-examples (companion change), since the MPS
backend is deprecated for removal in ExecuTorch 1.4 (pytorch#18425) and the
test had been intermittently failing on the macos-14-xlarge runner pool
on what looks like fp16 numerical drift rather than an executorch
regression — the MPS runtime in pytorch/executorch hasn't materially
changed since the deprecation.

Remove the matching `mps_example.py` export step from the two iOS
demo build scripts (the CI variant `.ci/scripts/test_ios_ci.sh` and
the developer-facing `scripts/test_ios.sh`) so neither produces an
`.pte` that nothing consumes. Out of scope here: the demo app's MPS
enum case and `mv3_mps_float16.pte` artifact in the executorch-examples
build workflow — those want their own follow-up cleanup once MPS is
fully removed in 1.4.

Authored with Claude Code.
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 5, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19303

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Awaiting Approval, 3 New Failures, 1 Pending, 7 Unrelated Failures

As of commit e0b6adb with merge base 08b2987 (image):

AWAITING APPROVAL - The following workflow needs approval before CI can run:

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant