Skip to content

Add pybindings for TextLLMRunner#17481

Merged
larryliu0820 merged 1 commit intopytorch:mainfrom
NickCao:text-llm-runner
Feb 20, 2026
Merged

Add pybindings for TextLLMRunner#17481
larryliu0820 merged 1 commit intopytorch:mainfrom
NickCao:text-llm-runner

Conversation

@NickCao
Copy link
Copy Markdown
Contributor

@NickCao NickCao commented Feb 16, 2026

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 16, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17481

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 179 Pending

As of commit b88ef54 with merge base cd32e42 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Feb 16, 2026

Hi @NickCao!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@NickCao NickCao force-pushed the text-llm-runner branch 2 times, most recently from acde4f0 to b40a829 Compare February 16, 2026 15:21
@NickCao
Copy link
Copy Markdown
Contributor Author

NickCao commented Feb 16, 2026

@pytorchbot label "release notes: llm"

@pytorch-bot pytorch-bot Bot added the release notes: llm Changes to llm utilities label Feb 16, 2026
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Feb 16, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 16, 2026
@nil-is-all nil-is-all added the module: llm Issues related to LLM examples and apps, and to the extensions/llm/ code label Feb 17, 2026
@nil-is-all
Copy link
Copy Markdown
Contributor

Hi @NickCao, thanks for the PR. Do check the lint runner check and address it.

@larryliu0820
Copy link
Copy Markdown
Contributor

This error seems to be valid

error: static assertion failed: def_property family does not currently support keep_alive. Use a py::cpp_function instead.

Take a look?

@NickCao
Copy link
Copy Markdown
Contributor Author

NickCao commented Feb 17, 2026

This error seems to be valid

error: static assertion failed: def_property family does not currently support keep_alive. Use a py::cpp_function instead.

Take a look?

No new invocations of def_property is introduced in this PR? rg keep_alive also returns nothing (only in third-party code).

@larryliu0820
Copy link
Copy Markdown
Contributor

ok I'll help you merge this

@larryliu0820 larryliu0820 merged commit 8972b69 into pytorch:main Feb 20, 2026
287 of 294 checks passed
@NickCao NickCao deleted the text-llm-runner branch February 25, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: llm Issues related to LLM examples and apps, and to the extensions/llm/ code release notes: llm Changes to llm utilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pybindings for text LLM runner

3 participants