Bump ASMJIT to 1.18#4850
Open
cyyever wants to merge 1 commit intopytorch:mainfrom
Open
Conversation
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Contributor
Author
|
@q10 We should check interface compatibility with other META projects using older ASMJIT, just like when we bumped it to v1.17. |
Contributor
|
@cyyever I think we might need to hold off on this upgrade for the moment. I took a look at the internal codebase, and there appears to be multiple large projects that rely on asmjit, and upgrading asmjit here requires upgrading all of those other projects in unison, which is very risky, not to mention that we unfortunately don't have the bandwidth to undertake and verify such a large change at the moment. Thank you for your understanding. |
Contributor
Author
|
@q10 Understand it. That case is anticipated. |
cyyever
force-pushed
the
asmjit_1.18
branch
7 times, most recently
from
0db1c64 to
6a9f8d8
Compare
Contributor
Author
|
@q10 I introduced a compatibility layer. |
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The author has changes the naming convention to snake_case. I am not sure whether it will break META internal builds..