Enable fp32 tests for Windows#4722
Draft
cyyever wants to merge 2 commits intopytorch:mainfrom
Draft
Conversation
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cyyever
force-pushed
the
enable_fp32_win
branch
3 times, most recently
from
b193d3f to
7e835e8
Compare
Contributor
Contributor
Contributor
|
@cyyever windows builds appear to be failing still :( |
cyyever
force-pushed
the
enable_fp32_win
branch
3 times, most recently
from
ffe18e1 to
51c8771
Compare
cyyever
force-pushed
the
enable_fp32_win
branch
from
51c8771 to
ad53701
Compare
cyyever
force-pushed
the
enable_fp32_win
branch
7 times, most recently
from
4b3ab7a to
c282572
Compare
Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: cyy <cyyever@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/fp32/FbgemmFP32.cc could work on Windows by commenting out ASM code.