Skip to content

fix: 어드민의 알림 전송 페이지에서 한국 전화번호 패턴도 허용하도록 수정 #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MU-Software wants to merge 1 commit into
base: refactor/remove-namespace-usage
Choose a base branch
from
Open

fix: 어드민의 알림 전송 페이지에서 한국 전화번호 패턴도 허용하도록 수정 #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/pyconkr-admin/src/components/pages/notification/send_history_create.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,11 @@ const NotAppliableToAllRecipientsFieldList = [
const URL_REGEX = /^[a-z0-9-]+(\.[a-z0-9-]+)+([/?].*)?$/;
const EMAIL_REGEX = /^[^\s@]+@[^\s@]+\.[^\s@]+$/;
const INTERNATIONAL_PHONE_REGEX = /^\+\d{1,4}[-\s]?\d+(?:[-\s]?\d+)*$/;
const KOREAN_PHONE_REGEX = /^01[016-9][-\s]?\d{3,4}[-\s]?\d{4}$/;

const isValidEmail = (value: string) => EMAIL_REGEX.test(value);
const isValidUrl = (value: string) => URL_REGEX.test(value);
const isValidPhone = (value: string) => URL_REGEX.test(value) || INTERNATIONAL_PHONE_REGEX.test(value);
const isValidPhone = (value: string) => KOREAN_PHONE_REGEX.test(value) || INTERNATIONAL_PHONE_REGEX.test(value);

const validateRecipientForApp = (app: NotificationChannelApp, value: string): string | null => {
const trimmed = value.trim();
Expand Down