Skip to content

Add typing support for dynamic colorful styles#15835

Open
Aniketsy wants to merge 3 commits into
python:mainfrom
Aniketsy:fix-15012
Open

Add typing support for dynamic colorful styles#15835
Aniketsy wants to merge 3 commits into
python:mainfrom
Aniketsy:fix-15012

Conversation

@Aniketsy
Copy link
Copy Markdown

fixes #15012

If I understand how colorful works correctly, I fear the only possible solution is to basically copy the whole API of Colorful into colorful/__init__.pyi, including __getattr__, which means that indeed colorful.<anything> is allowed when it comes to types.

followed @srittau suggestion,

please let me know if we need to do further improvement or if i misunderstood anything. Thanks!

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

colorful how to handle dynamic types

1 participant