perf: cache link objects that have been created lazily

[radoering]

#10951 prevented the creation of unnecessary link objects. However, this also resulted in link objects that were requested multiple times being created multiple times. Depending on a project's dependencies the first or the latter is more relevant. Thus, a two-stage cache makes sense to get the best of both.

[sourcery-ai]

Hey - I've found 1 issue

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="src/poetry/repositories/link_sources/base.py" line_range="175-180" />
<code_context>
         return True

     @cached_property
-    def _link_cache(self) -> LinkCache:
-        raise NotImplementedError()
+    def _link_factory_cache(self) -> LinkFactoryCache:
+        """ATTENTION:
+        The factories should only be called in links_for_version
+        so that the __link_cache, which avoids to call the same factory twice,
+        is populated.
+        """
</code_context>
<issue_to_address>
**nitpick (typo):** Polish the wording in the `_link_factory_cache` docstring for clarity.

The phrase "avoids to call the same factory twice" is awkward. Please rephrase to something like "avoids calling the same factory twice" for smoother wording.

```suggestion
    def _link_factory_cache(self) -> LinkFactoryCache:
        """ATTENTION:
        The factories should only be called in links_for_version
        so that the __link_cache, which avoids calling the same factory twice,
        is populated.
        """
```
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}