Skip to content

fix: Add some benchmark tests (#37)#678

Closed
princ0301 wants to merge 1 commit into
pytest-dev:mainfrom
princ0301:fix-37-add-some-benchmark-tests
Closed

fix: Add some benchmark tests (#37)#678
princ0301 wants to merge 1 commit into
pytest-dev:mainfrom
princ0301:fix-37-add-some-benchmark-tests

Conversation

@princ0301
Copy link
Copy Markdown

Fixes #37

Summary

Fixes the wrapper plugin signature in the test_call_hook benchmark. The original signature did not account for the arguments passed during the hook call, which would lead to a TypeError.

Validation

Tests passing after 1 attempt(s).

debconf: unable to initialize frontend: Readline
debconf: (Can't locate Term/ReadLine.pm in @INC (you may need to install the Term::ReadLine module) (@INC entries checked: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.40.1 /usr/local/share/perl/5.40.1 /usr/lib/x86_64-linux-gnu/perl5/5.40 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.40 /usr/share/perl/5.40 /usr/local/lib/site_perl) at /usr/share/perl5/Debconf/FrontEnd/Readline.pm line 8, <STDIN> line 49.)
debconf: falling back to frontend: Teletype
debconf: unable to initialize frontend: Teletype
debconf: (This frontend requires a controlling tty.)
debconf: falling back to frontend: Noninteractive
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager, possibly rendering your system unusable. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv. Use the --root-user-action option if you know what you are doing and want to suppress this warning.
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager, possibly rendering your system unusable. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv. Use the --root-user-action option if you know what you are doing and want to suppress this warning.
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager, possibly rendering your system unusable. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv. Use the --root-user-action option if you know what you are doing and want to suppress this warning.
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager, possibly rendering your system unusable. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv. Use the --root-user-action option if you know what you are doing and want to suppress this warning.

@princ0301
Copy link
Copy Markdown
Author

Closing this for now because, although the change passes CI, it does not clearly address the original goal of issue #37 to add benchmark tests in the way intended. I’d rather revisit this with a more issue-aligned implementation than keep a potentially misleading PR open.

@princ0301 princ0301 closed this May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add some benchmark tests

1 participant