dont exclude tests from build, fix windows path refs#267
Merged
Conversation
aerispaha
changed the title
aerispaha
commented
May 22, 2026
|
|
||
| # path to the Python executable used to run your version of Python | ||
| PYTHON_EXE_PATH = "python"#os.path.join(os.__file__.split("lib/")[0],"bin","python") | ||
| PYTHON_EXE_PATH = sys.executable |
Member
Author
There was a problem hiding this comment.
this ensures we find the right python executable/binary in whatever OS we're in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the pychrs.tests module was not included in the build. This was a problem because we reference the test module in some examples.
While making this fix, I also noticed that tests were actually failing in Windows even though GitHub Actions wasn't flagging them as failures in Windows because previously we did the tests and doctests in the same command. now they run in distinct steps, so windows failures will be raised in the future.
I fixed the issues in windows by making a few path references OS-dynamic and configured matplotlib properly for headless environments in test_graphics.