Push renamed changelog to PR branch in upgrade workflow - #3213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Rename changelog with PR number" step in
upgrade.yamlchecks out the localauto/upgrade-embedded-depsbranch that create-pull-request left behind (no upstream configured) and then runs a baregit push, which fails withfatal: The current branch auto/upgrade-embedded-deps has no upstream branch(https://github.com/pypa/virtualenv/actions/runs/31094988576, https://github.com/pypa/virtualenv/actions/runs/31307714056); the runs since then are green only because no upgrade was pending. The step now checks outFETCH_HEADfrom the fetch it already does, so it works on what is actually on the remote for both the created and updated paths, and pushes explicitly withgit push origin HEAD:auto/upgrade-embedded-deps.