Skip to content

Add python-version to pyvenv.cfg for PEP 838 #3193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
konstin wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −3
Draft

Add python-version to pyvenv.cfg for PEP 838 #3193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
116f079
Add python-version to pyvenv.cfg
konstin Jul 21, 2026
36189be
Add changelog entry
konstin Jul 21, 2026
29291aa
Simplify set_pyenv_cfg and its version test
gaborbernat Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changelog/3193.feature.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add the PEP 838 ``python-version`` field to ``pyvenv.cfg``.
6 changes: 4 additions & 2 deletions src/virtualenv/create/creator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,10 @@ def set_pyenv_cfg(self) -> None:
assert system_executable is not None # ruff:ignore[assert]
self.pyenv_cfg["home"] = os.path.dirname(os.path.abspath(system_executable))
self.pyenv_cfg["implementation"] = self.interpreter.implementation
self.pyenv_cfg["version_info"] = ".".join(str(i) for i in self.interpreter.version_info)
self.pyenv_cfg["version"] = ".".join(str(i) for i in self.interpreter.version_info[:3])
version_info = self.interpreter.version_info
self.pyenv_cfg["python-version"] = f"{version_info.major}.{version_info.minor}"
self.pyenv_cfg["version_info"] = ".".join(str(i) for i in version_info)
self.pyenv_cfg["version"] = ".".join(str(i) for i in version_info[:3])
self.pyenv_cfg["executable"] = os.path.realpath(system_executable)
self.pyenv_cfg["command"] = f"{sys.executable} -m virtualenv {self.dest}"
self.pyenv_cfg["virtualenv"] = __version__
Expand Down
3 changes: 2 additions & 1 deletion tests/unit/create/test_creator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,9 +326,10 @@ def test_prompt_set(tmp_path: Path, creator: str, prompt: str | None, monkeypatc


@pytest.mark.parametrize("creator", CURRENT_CREATORS)
def test_version_key_in_pyenv_cfg(tmp_path: Path, creator: str) -> None:
def test_version_keys_in_pyenv_cfg(tmp_path: Path, creator: str) -> None:
result = cli_run([str(tmp_path), "--seeder", "app-data", "--without-pip", "--creator", creator])
cfg = PyEnvCfg.from_file(result.creator.pyenv_cfg.path)
assert cfg["python-version"] == f"{sys.version_info.major}.{sys.version_info.minor}"
assert "version" in cfg
parts = cfg["version"].split(".")
assert len(parts) == 3
Expand Down
Loading